Adds PPS Source Activate function #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62022960 |
Summary: Pull Request resolved: facebook#394 WHAT? implements ts2phc_phc_pps_source_activate from ts2phc_phc_pps_source.c WHY? Remove dependency on linuxptp by rewriting ts2phc.c (T196935923) Considerations: Why no tests? - Tests are added in a seperate diff D62447639 Why are index, channel, etc... not arguments of ActivatePPSSource? - They will ilkely become so in a future diff, when this is used as a part of the entire ts2phc flow. Reviewed By: leoleovich Differential Revision: D62022960
|
This pull request was exported from Phabricator. Differential Revision: D62022960 |
crmdias
force-pushed
the
export-D62022960
branch
from
9b5671c to
a70b87d
Compare
|
This pull request has been merged in dd62cd4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
WHAT?
implements ts2phc_phc_pps_source_activate from ts2phc_phc_pps_source.c
WHY?
Remove dependency on linuxptp by rewriting ts2phc.c (T196935923)
Considerations:
Why no tests?
Why are index, channel, etc... not arguments of ActivatePPSSource?
Reviewed By: leoleovich
Differential Revision: D62022960